Skip to content

chore: Testing for invalid changelogs #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

chore: Testing for invalid changelogs #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e2d6e4
chore: Return error when calling changelog command
bflad Jun 7, 2025
5176d64
chore: Use pr Docker image
bflad Jun 7, 2025
5503cbd
chore: point workflow at branch
bflad Jun 7, 2025
d938e73
chore: More debugging
bflad Jun 7, 2025
d806656
chore: More debugging
bflad Jun 7, 2025
55980e6
chore: More debugging
bflad Jun 8, 2025
6bc3f3c
chore: More debugging
bflad Jun 8, 2025
130ed65
chore: Set log level environment variable rather than debug/verbose f…
bflad Jun 8, 2025
2447322
chore: Enable GHA cache for Docker build
bflad Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ jobs:
type=sha,format=long

- name: Build and push Docker image
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6,18.0
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
with:
cache-from: type=gha
cache-to: type=gha,mode=max
context: .
platforms: linux/amd64,linux/arm64,linux/arm64/v8
push: true
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/workflow-executor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:
- id: run-workflow
name: Run Generation Workflow
if: ${{ steps.check-label.outputs.short_circuit_label_trigger != 'true' }}
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
github_access_token: ${{ secrets.github_access_token }}
Expand Down Expand Up @@ -250,7 +250,7 @@ jobs:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
name: Log Generation Output
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: ${{ steps.check-label.outputs.short_circuit_label_trigger != 'true'}}
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
python setup.py sdist bdist_wheel
twine upload dist/*
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -341,7 +341,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -386,7 +386,7 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.npm_token }}
run: npm publish --access public
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -411,7 +411,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -472,7 +472,7 @@ jobs:
SONATYPE_SIGNING_KEY: ${{ secrets.java_gpg_secret_key }}
SIGNING_KEY_PASSPHRASE: ${{ secrets.java_gpg_passphrase }}
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -497,7 +497,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -547,7 +547,7 @@ jobs:
gem build *.gemspec
gem push *.gem
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -572,7 +572,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -612,7 +612,7 @@ jobs:
- name: Publish
run: dotnet pack -c Release -o . && dotnet nuget push *.nupkg --api-key ${{ secrets.nuget_api_key }} --source https://api.nuget.org/v3/index.json
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -637,7 +637,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down Expand Up @@ -678,7 +678,7 @@ jobs:
repository_name: ${{ github.repository }}
repository_base_url: ${{ github.server_url }}
- id: publish-event
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
github_access_token: ${{ secrets.github_access_token }}
Expand All @@ -703,7 +703,7 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
- id: log-result
uses: speakeasy-api/sdk-generation-action@v15
uses: speakeasy-api/sdk-generation-action@invalid-changelog
if: always()
with:
speakeasy_version: ${{ inputs.speakeasy_version }}
Expand Down
2 changes: 1 addition & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ outputs:
description: "The release tag used for standalone ts mcp binaries"
runs:
using: "docker"
image: "docker://ghcr.io/speakeasy-api/sdk-generation-action:v15"
image: "docker://ghcr.io/speakeasy-api/sdk-generation-action:pr-228"
env:
SPEAKEASY_API_KEY: ${{ inputs.speakeasy_api_key }}
SPEAKEASY_SERVER_URL: ${{ inputs.speakeasy_server_url }}
Expand Down
3 changes: 3 additions & 0 deletions internal/actions/runWorkflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"os"
"strings"

"github.com/davecgh/go-spew/spew"
"github.com/google/go-github/v63/github"
"github.com/pkg/errors"
"github.com/speakeasy-api/sdk-generation-action/internal/utils"
Expand Down Expand Up @@ -172,6 +173,8 @@ func RunWorkflow() error {
return nil
}

return fmt.Errorf("Run res: %s", spew.Sdump(runRes))

if err := finalize(finalizeInputs{
Outputs: outputs,
BranchName: branchName,
Expand Down
2 changes: 2 additions & 0 deletions internal/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,8 @@ func GetChangelog(lang, genVersion, previousGenVersion string, targetVersions ma
args = append(args, "-p", strings.Join(previosVersionsStrings, ","))
}

return "", fmt.Errorf("About to run changelog command: %s", strings.Join(args, " "))

out, err := runSpeakeasyCommand(args...)
if err != nil {
return "", err
Expand Down
2 changes: 2 additions & 0 deletions internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ func Run(sourcesOnly bool, installationURLs map[string]string, repoURL string, r
"run",
}

os.Setenv("SPEAKEASY_LOG_LEVEL", "debug")

if sourcesOnly {
args = append(args, "-s", "all")
} else {
Expand Down
Loading