Skip to content

fix: speakeasy run doesn't print out registry uris used for code samples in the output #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
Merged

fix: speakeasy run doesn't print out registry uris used for code samples in the output #1653

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
696c84f
fix: guard against empty code samples url
adaam2 Oct 7, 2025
df65366
fix: code samples
adaam2 Oct 7, 2025
28da714
fix: formatting
adaam2 Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,12 @@ func (w *Workflow) printGenerationOverview(ctx context.Context) error {
additionalLines = append(additionalLines, "Review all targets with `speakeasy status`.")
}

if t.CodeSamples != nil {
// Covers the case where code samples are configured to be written to a local file
if t.CodeSamples != nil && t.CodeSamples.Output != "" {
additionalLines = append(additionalLines, fmt.Sprintf("Code samples overlay file written to %s", t.CodeSamples.Output))
// Covers the case where code samples are configured to be published to a registry URI
} else if t.CodeSamples != nil && t.CodeSamples.Registry != nil {
additionalLines = append(additionalLines, fmt.Sprintf("Code samples uploaded to: %s", string(t.CodeSamples.Registry.Location)))
}

if len(w.criticalWarns) > 0 {
Expand Down
Loading