-
-
Notifications
You must be signed in to change notification settings - Fork 781
Fix/multiple content type headers lead to 415 consistently #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -310,10 +310,8 @@ def extract_content_type( | |
|
|
||
| if decoded_key.lower() == "content-type": | ||
| if isinstance(value, bytes): | ||
| content_type = value.decode("latin-1") | ||
| else: | ||
| content_type = value | ||
| break | ||
| value = value.decode("latin-1") | ||
| content_type = ",".join([content_type, value] if content_type else [value]) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be only one content-type header. If there are multiple, I believe it is more appropriate to raise a BadRequest error to return a 400 status code |
||
|
|
||
| return content_type | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -175,3 +175,26 @@ class MyDefaultsJSONBodyValidator(DefaultsJSONRequestBodyValidator): | |
| ) | ||
| assert res.status_code == 200 | ||
| assert res.json().get("human") | ||
|
|
||
|
|
||
| def test_multiple_json_content_type(json_validation_spec_dir, spec): | ||
| """ensure that defaults applied that modify the body""" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The docstring is the one from the test above, it should be about multiple content type headers? |
||
|
|
||
| class MyDefaultsJSONBodyValidator(DefaultsJSONRequestBodyValidator): | ||
| pass | ||
|
|
||
| validator_map = {"body": {"application/json": MyDefaultsJSONBodyValidator}} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we need to update the custom body validator in this test |
||
|
|
||
| app = App(__name__, specification_dir=json_validation_spec_dir) | ||
| app.add_api(spec, validate_responses=True, validator_map=validator_map) | ||
| app_client = app.test_client() | ||
|
|
||
| res = app_client.post( | ||
| "/v1.0/user", | ||
| data=json.dumps({"name": "foo"}), | ||
| headers={ | ||
| "content-type": "application/json", | ||
| "Content-Type": "application/json", | ||
| }, | ||
| ) | ||
| assert res.status_code == 415 | ||
Uh oh!
There was an error while loading. Please reload this page.