Skip to content

fix(core/pubsubhub): log errors from event handlers #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sidvishnoi merged 2 commits into from
Nov 26, 2024
Merged

fix(core/pubsubhub): log errors from event handlers #4833

sidvishnoi merged 2 commits into from
Nov 26, 2024

Conversation

@sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Nov 22, 2024 •
edited
Loading

Part of #4825

Instead of rsError being null (from global window.onerror listener), create rsError properly:
image

@sidvishnoi sidvishnoi marked this pull request as ready for review November 26, 2024 08:55
@sidvishnoi sidvishnoi merged commit fae88d4 into main Nov 26, 2024
7 checks passed
@sidvishnoi sidvishnoi deleted the catch-pub-sub-errors branch November 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoscaceres marcoscaceres Awaiting requested review from marcoscaceres

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sidvishnoi