fix(w3c/headers): allow forcing /TR namespace for TAG/AB
#5085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… latest published version in the edcopy
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sidvishnoi
reviewed
Nov 24, 2025
src/w3c/headers.js
Outdated
|
|
||
| if (conf.groupType === "other" && | ||
| (conf.group === "tag" || conf.group === "ab") && | ||
| conf.canonicalURI === "TR") { |
Member
There was a problem hiding this comment.
Can we require conf.canonicalURI === "TR" (at line 653) for all those who want to opt-in, not just TAG/AB (skipping group/groupType checks here)?
Contributor
Author
There was a problem hiding this comment.
TAG and AB can publish on /TR, the WG case is already handled, I don't think any other group can publish in /TR right now, that why I added that extra test.
sidvishnoi
changed the title
/TR namespace for TAG/AB
sidvishnoi
reviewed
Nov 24, 2025
sidvishnoi
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5084
The solution rely on using canonicalURI = "TR" in the ReSpec config.