-
Notifications
You must be signed in to change notification settings - Fork 1
PCP-4952: use kubeconfig ca certs for workernode bootstrapping #978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spectro-master
Are you sure you want to change the base?
Conversation
…g secret instead of EKS API. This change simplifies the CA retrieval process and improves error handling for missing CA data.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pavansokkenagaraj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
b687c16d8c38fb4a8a2c1c7f966173e52dc3763e:spectro/generated/core-global.yaml:aws-access-token:3706
- File:
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
b687c16d8c38fb4a8a2c1c7f966173e52dc3763e:spectro/generated/core-global.yaml:aws-access-token:3812
- File:
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
b687c16d8c38fb4a8a2c1c7f966173e52dc3763e:spectro/generated/core-global.yaml:generic-api-key:16196
- File:
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
24c392cf5c536e0bb8d3be1e6205dd8968a453eb:spectro/generated/core-global.yaml:aws-access-token:3287
- File:
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
24c392cf5c536e0bb8d3be1e6205dd8968a453eb:spectro/generated/core-global.yaml:aws-access-token:3394
- File:
-
- File:
spectro/generated/core-global.yaml - Fingerprint:
24c392cf5c536e0bb8d3be1e6205dd8968a453eb:spectro/generated/core-global.yaml:aws-access-token:3492
- File:
Please review these findings and remove any sensitive information before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- GO-2025-3754
- Module: github.com/cloudflare/circl
- Found in: v1.3.7
- Fixed in: v1.6.1
- Example Traces:
#1: test/helpers/kubernetesversions/template.go:37:2: kubernetesversions.init calls framework.init, which eventually calls goldilocks.init
#2: test/helpers/kubernetesversions/template.go:37:2: kubernetesversions.init calls framework.init, which eventually calls ed25519.init
#3: test/helpers/kubernetesversions/template.go:37:2: kubernetesversions.init calls framework.init, which eventually calls ed25519.init
#4: test/helpers/kubernetesversions/template.go:37:2: kubernetesversions.init calls framework.init, which eventually calls ed448.init
#5: test/helpers/kubernetesversions/template.go:37:2: kubernetesversions.init calls framework.init, which eventually calls ecc.init
- GO-2025-3595
- Module: golang.org/x/net
- Found in: v0.33.0
- Fixed in: v0.38.0
- Example Traces:
#1: pkg/rosa/externalauthproviders.go:52:35: rosa.UpdateExternalAuth calls v1.Send, which eventually calls bluemonday.sanitize
- GO-2025-3553
- Module: github.com/golang-jwt/jwt/v4
- Found in: v4.5.1
- Fixed in: v4.5.2
- Example Traces:
#1: pkg/rosa/client.go:51:70: rosa.NewOCMClient calls ocm.Build, which eventually calls authentication.Build
Please review these findings and fix the issues before merging.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: