Skip to content

1218 bug processnetstat is funky#1330

Merged
hulto merged 29 commits intomainfrom
1218-bug-processnetstat-is-funky
Dec 27, 2025
Merged

1218 bug processnetstat is funky#1330
hulto merged 29 commits intomainfrom
1218-bug-processnetstat-is-funky

Conversation

@hulto
Copy link
Copy Markdown
Collaborator

@hulto hulto commented Dec 18, 2025

What type of PR is this?

/kind bug
/kind feature

image

What this PR does / why we need it:

  • Remove dependency on listeners crate
  • Adds new netstat lib
  • Implements macos, windows, and linux netstat
  • Updates windows_sys library

Which issue(s) this PR fixes:

Fixes #1218

@hulto hulto linked an issue Dec 18, 2025 that may be closed by this pull request
use anyhow::Result;

pub fn netstat() -> Result<Vec<NetstatEntry>> {
// TODO: Implement FreeBSD sysctl using net.inet.tcp.pcblist
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implement this.

@KCarretto
Copy link
Copy Markdown
Collaborator

imho we should make the changes to eldritchv2-final and fix forward

@hulto hulto requested a review from KCarretto December 24, 2025 02:31
@hulto hulto marked this pull request as ready for review December 24, 2025 02:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 24, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
17494    ±0 17493    ±0 1    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#29 17494 17493 1 0 0 0 27.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
17494 0 1 44.9s

Fail Rate

Fail Rate 0.01%    ±0
Test 📝 Results 📊 Passed ✅ Failed ❌ Fail Rate (%) 📈
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76
eldritch: file::moveto_impl::tests::test_moveto_file 21 20 1 4.76    ↑4.76

Failed Tests

Failed Tests
❌ eldritch: file::moveto_impl::tests::test_moveto_file
Error: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmppJ2JkY"

Trace:

Error: Access is denied. (os error 5) at path "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\.tmppJ2JkY"

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s
eldritch: random::string_impl::tests::test_string_uniform 20 39.7s 44.9s

🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@hulto hulto requested a review from KCarretto December 26, 2025 02:02
@hulto hulto merged commit d754855 into main Dec 27, 2025
7 checks passed
@hulto hulto deleted the 1218-bug-processnetstat-is-funky branch December 27, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] process.netstat() is funky

2 participants