Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Switched git clone to use filesystem storage and implemented chunked file import to fix 502 errors on large repos.


PR created automatically by Jules for task 4289647028691068845 started by @KCarretto

This change modifies the `Import` logic in `tavern/tomes/git.go` to use
`filesystem.NewStorage` backed by a temporary directory instead of in-memory storage,
preventing memory exhaustion when importing large repositories.

Additionally, `importFromGitTree` has been refactored to:
1. Fetch and parse `metadata.yml` and `main.eldritch` before processing other assets.
2. Create the Tome entity first.
3. Process remaining assets in chunks (batch size 100), creating File entities and linking them to the Tome incrementally, to avoid building massive SQL queries and reducing memory footprint.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2763    ±0 2763    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#200 2763 2763 0 0 0 0 26.9s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2763 0 0 43.4s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch: random::string_impl::tests::test_string_uniform 3 39.6s 43.4s
eldritch: random::string_impl::tests::test_string_uniform 3 39.6s 43.4s
eldritch: random::string_impl::tests::test_string_uniform 3 39.6s 43.4s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 3.2s 9.3s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 3.2s 9.3s
eldritch: pivot::port_scan_impl::tests::test_portscan_return_type_starlark_dict_from_interpreter 3 3.2s 9.3s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.5s 9.3s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.5s 9.3s
eldritch: pivot::ssh_copy_impl::tests::test_pivot_ssh_copy 3 4.5s 9.3s
eldritch: process::info_impl::tests::test_info_default 3 3.3s 9.3s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@hulto hulto closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants