Refactor Reverse Shell to use Portals #1537
Conversation
- Defined `REPLMessage` in `portal.proto`.
- Removed `ReverseShell` from `c2.proto`.
- Updated `imixv2` (agent) to use `create_portal` for REPL and PTY.
- Updated `transport` crate to remove `reverse_shell`.
- Updated `tavern` (server):
- Rewrote `websocket.go` to bridge WebSocket to `portalMux` using `Portal` entities.
- Updated `api_create_portal.go` to handle keepalives.
- Removed legacy `api_reverse_shell.go` and related tests.
- Regenerated Go protos.
- Cleaned up unused code and updated tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
implants/lib/pb/build.log
Outdated
| @@ -0,0 +1,231 @@ | |||
| Fresh unicode-ident v1.0.22 | |||
There was a problem hiding this comment.
Jules, remove this log file
There was a problem hiding this comment.
Removed implants/lib/pb/build.log.
- Removed `implants/lib/pb/build.log` which was accidentally committed.
- Updated `tavern/internal/http/stream/websocket.go` to use `portalMux` and bridge WebSocket messages to `Mote`s with `REPLMessage` payloads. - Updated `NewShellHandler` to accept `portal_id` (via `shell_id` param) and verify `Portal` existence. - Updated `tavern/app.go` to pass `portalMux` to WebSocket handlers and remove old shell mux initialization. - Updated `tavern/config.go` to remove `NewShellMuxes` configuration. - Deleted obsolete mux code in `tavern/internal/http/stream/`: `stream.go`, `mux.go`, `circular_buffer.go`, `gcp_coldstart.go` and their tests. - Re-verified tests pass.
Refactored the legacy gRPC-based Reverse Shell to use the new Portals infrastructure.
This involves changes to the Protocol Buffers, the Rust agent (
imixv2), thetransportlibrary, and the Go C2 server (tavern).The
ReverseShellRPC has been replaced byCreatePortalcarryingMotes withReplMessagepayloads.The WebSocket handler in
tavernnow bridges to thePortalMuxinstead of the legacystream.Mux.PR created automatically by Jules for task 9871010882071058583 started by @KCarretto