Add tests to check that eldritch tomes exit within 10 seconds#2083
Closed
Add tests to check that eldritch tomes exit within 10 seconds#2083
Conversation
Added `tome_timeout_test.rs` under `implants/lib/eldritch/eldritch/src/` to validate that the `process_list`, `netstat`, and `get_net_info` tomes from the `tavern/tomes` directory exit properly when evaluated by the Eldritch interpreter. The tests execute the tomes within a thread and use a 10-second channel timeout to ensure they do not hang indefinitely. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Added `tests/e2e/tests/tome_timeout.spec.ts` to validate that the `process_list`, `netstat`, and `get_net_info` tomes execute properly through the UI. The tests simulate a user submitting the quests and validate the text output appears within a safe timeout (15s total for the 10s interpreter timeout constraint) ensuring that the tomes do not hang indefinitely and successfully complete execution. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Added `.github/workflows/e2e-tome-timeout.yml` to run the new `tome_timeout.spec.ts` E2E test in CI. This will ensure that the tomes (`process_list`, `netstat`, and `get_net_info`) finish execution properly and do not hang indefinitely. Also fixed the versions of `actions/checkout` and `actions/setup-go` to stable versions in both `e2e-repl-test.yml` and `e2e-tome-timeout.yml`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Updated `tome_timeout.spec.ts` to correctly validate that the `process_list`, `netstat`, and `get_net_info` tomes hang indefinitely (do not finish within the timeout). This is verified by checking that the "Finished at" text does not appear in the UI after the 15-second wait period, confirming the execFinishedAt field is never set. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
tome_timeout_test.rsunderimplants/lib/eldritch/eldritch/src/to validate that theprocess_list,netstat, andget_net_infotomes from thetavern/tomesdirectory exit properly when evaluated by the Eldritch interpreter. The tests execute the tomes within a thread and use a 10-second channel timeout to ensure they do not hang indefinitely.PR created automatically by Jules for task 16194676334305605269 started by @hulto