Fix Lexer Error Formatting for Task Execution#2089
Conversation
Previously, Lexer errors were returned as raw strings without the surrounding context snippet, whereas parser syntax errors correctly used `format_error`. This ensures all syntax errors bubble up with line information and visual context via `TaskError`. Added two tests in imix/src/tests/ to verify that unclosed string literals and malformed function definitions are safely caught and reported as errors back to the C2 backend. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
eldritch-coreinterpreter to wrapLexererrors in anEldritchErrorand route them throughformat_error. This gives them the same context snippets as parser errors.test_task_syntax_error(lexer unclosed string) andtest_task_syntax_error_parse(parser syntax error) to verify that syntax-violating Tasks don't crash the agent, but properly reportTaskErrorpayloads back to the C2 server overMockAgent's report mechanisms.PR created automatically by Jules for task 1008156907656023745 started by @KCarretto