Skip to content

[AI] Refactor Test Coverage - Centralized MockAgent#2091

Merged
KCarretto merged 1 commit intomainfrom
ai/centralized-mock-agent-13145434703601781316
Mar 16, 2026
Merged

[AI] Refactor Test Coverage - Centralized MockAgent#2091
KCarretto merged 1 commit intomainfrom
ai/centralized-mock-agent-13145434703601781316

Conversation

@KCarretto
Copy link
Collaborator

This PR centralizes scattered MockAgent test implementations found across the eldritch standard libraries into a single unified eldritch-mockagent crate inside the testutils directory.

By unifying this codebase, duplicated boilerplate testing code is eliminated, making it easier to extend eldritch_agent::Agent behavior mocks in the future.

Key Changes

  • Created implants/lib/eldritch/testutils/eldritch-mockagent.
  • Linked eldritch-mockagent to Cargo.toml as a dev-dependency for eldritch-libagent, eldritch-libassets, eldritch-libpivot, and eldritch.
  • Refactored all affected tests to utilize eldritch_mockagent::MockAgent instead of local structs.
  • Confirmed stability with cargo check and cargo test passing smoothly.

PR created automatically by Jules for task 13145434703601781316 started by @KCarretto

- Creates a generic `MockAgent` testing utility in `implants/lib/eldritch/testutils/eldritch-mockagent` supporting mocking of `config`, `assets`, `process_list`, and call tracking.
- Updates `eldritch-libagent`, `eldritch-libassets`, `eldritch-libpivot`, and `eldritch` crates to use `eldritch-mockagent` as a dev-dependency instead of duplicating boilerplate.
- Removes redundant mock implementations.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2820    ±0 2820    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1736 2820 2820 0 0 0 0 36.1s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2820 0 0 5.9s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.9s 5.9s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.1s 5.1s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.8s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.9s 3.9s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review March 16, 2026 01:23
@KCarretto KCarretto merged commit 0824941 into main Mar 16, 2026
8 checks passed
@KCarretto KCarretto deleted the ai/centralized-mock-agent-13145434703601781316 branch March 16, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants