Skip to content

Fix socks5 proxy auth code handling and device auth UI#2115

Open
KCarretto wants to merge 1 commit intomainfrom
fix-socks5-auth-8863455242053099640
Open

Fix socks5 proxy auth code handling and device auth UI#2115
KCarretto wants to merge 1 commit intomainfrom
fix-socks5-auth-8863455242053099640

Conversation

@KCarretto
Copy link
Collaborator

Fixes the remote device authentication flow for ./bin/socks5 and CLI tools.

  1. Caches the token to .tavern-auth locally upon successful authentication.
  2. Fixes the /auth/rda/code API to return a populated verification_uri and verification_uri_complete depending on the request host.
  3. Added github.com/skip2/go-qrcode as a dependency and utilized it to print a scannable ASCII QR code to the CLI for easy device authentication.
  4. Auto-populates the input field on the /profile page with the device-code query parameter using react router hooks.
  5. Fixed a bug in the revocation flow in DeviceAuth.tsx where node.id was passed instead of node.userCode.

PR created automatically by Jules for task 8863455242053099640 started by @KCarretto

- Cache remote device auth credentials in .tavern-auth file
- Update RDA HTTP endpoint to return generated verification URIs
- Print scannable QR code during CLI remote device authentication
- Update DeviceAuth React component to prepopulate URL device-code
- Fix DeviceAuth Revoke handler to send userCode instead of node.id

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2833    ±0 2833    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1810 2833 2833 0 0 0 0 39.8s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2833 0 0 6.0s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.0s 6.0s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.9s
imix::bin/imix: install::tests::test_install_execution 3 1.7s 4.9s
TestDockerExecutor_Build_SimpleEcho 1 3.8s 3.8s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.1s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

@KCarretto KCarretto marked this pull request as ready for review March 20, 2026 14:44
@KCarretto KCarretto enabled auto-merge March 20, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant