Draft
Conversation
When chacha20poly1305 decryption fails (e.g., due to an authentication failure), the cryptocodec service will now properly propagate a grpc Unauthenticated error with the "auth failure" message instead of causing a generic internal server error. This ensures the agent accurately logs and handles the authentication failure rather than a 500 error. Updated `CryptoSvc.Decrypt` to return an error, and `StreamDecryptCodec.Unmarshal` to map that error to `status.Error(codes.Unauthenticated, "auth failure")`. Also updated corresponding test cases to handle the new return signature. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
Contributor
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagated specific grpc Unauthenticated error with "auth failure" on decryption error.
PR created automatically by Jules for task 12151100931827609295 started by @hulto