feat(eldritch): support bytes checking with the in operator#2124
feat(eldritch): support bytes checking with the in operator#2124
in operator#2124Conversation
Update `evaluate_in` to allow the `in` operator to match `Value::Bytes` as the right-hand operand. Valid left-hand operands include a subset of `Value::Bytes` or an individual byte represented as a `Value::Int`. Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Added support for the
inoperator onbytestypes in Eldritch. This allows checking if a byte subset or a specific integer (0-255) byte exists in abytessequence. Includes bounds checking and handles empty subset slices securely to prevent panics.Tests have been added to ensure proper coverage of
Value::Bytessequence finding with both sub-sequences and singleValue::Intinputs.PR created automatically by Jules for task 16234672380634810023 started by @hulto