Skip to content

feat(eldritch): support bytes checking with the in operator#2124

Open
hulto wants to merge 2 commits intomainfrom
eldritch-bytes-in-operator-16234672380634810023
Open

feat(eldritch): support bytes checking with the in operator#2124
hulto wants to merge 2 commits intomainfrom
eldritch-bytes-in-operator-16234672380634810023

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Mar 21, 2026

Added support for the in operator on bytes types in Eldritch. This allows checking if a byte subset or a specific integer (0-255) byte exists in a bytes sequence. Includes bounds checking and handles empty subset slices securely to prevent panics.

Tests have been added to ensure proper coverage of Value::Bytes sequence finding with both sub-sequences and single Value::Int inputs.


PR created automatically by Jules for task 16234672380634810023 started by @hulto

Update `evaluate_in` to allow the `in` operator to match `Value::Bytes` as the right-hand operand. Valid left-hand operands include a subset of `Value::Bytes` or an individual byte represented as a `Value::Int`.

Co-authored-by: hulto <7121375+hulto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@hulto hulto marked this pull request as ready for review March 22, 2026 00:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2836    ±0 2836    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1823 2836 2836 0 0 0 0 37.8s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2836 0 0 6.1s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 6.1s 6.1s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.1s 5.1s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
TestDockerExecutor_Build_SimpleEcho 1 3.9s 3.9s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant