Skip to content

Fix questTimelineChart metrics bucket alignment#2129

Merged
KCarretto merged 2 commits intomainfrom
fix-quest-timeline-chart-alignment-14729035637876417102
Mar 23, 2026
Merged

Fix questTimelineChart metrics bucket alignment#2129
KCarretto merged 2 commits intomainfrom
fix-quest-timeline-chart-alignment-14729035637876417102

Conversation

@KCarretto
Copy link
Collaborator

Fixes an issue where questTimelineChart was not properly bucketizing unaligned timestamp intervals.


PR created automatically by Jules for task 14729035637876417102 started by @KCarretto

Replaced integer duration division with `time.Truncate(granularity)` to ensure mathematically perfect bucket alignment and prevent edge-case tracking bugs over long periods. Also swapped map keys from `time.Time` to `int64` (Unix timestamps) to avoid any potential strict location/pointer reference mapping issues when processing Unmarshalled `time.Time` types. Added tests with unaligned data to confirm correctness.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@KCarretto KCarretto marked this pull request as ready for review March 23, 2026 03:59
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2837    ±0 2837    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#1838 2837 2837 0 0 0 0 38.2s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2837 0 0 5.5s

Test Changes

0 test added, 0 removed

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
TestDockerExecutor_Build_ContextCancellation 1 5.5s 5.5s
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
TestInteractiveShell 1 5.0s 5.0s
TestOtherStreamOutput 1 5.0s 5.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_eprint_behavior 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@KCarretto KCarretto merged commit c3df46b into main Mar 23, 2026
8 checks passed
@KCarretto KCarretto deleted the fix-quest-timeline-chart-alignment-14729035637876417102 branch March 23, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant