Fix questTimelineChart metrics bucket alignment#2129
Conversation
Replaced integer duration division with `time.Truncate(granularity)` to ensure mathematically perfect bucket alignment and prevent edge-case tracking bugs over long periods. Also swapped map keys from `time.Time` to `int64` (Unix timestamps) to avoid any potential strict location/pointer reference mapping issues when processing Unmarshalled `time.Time` types. Added tests with unaligned data to confirm correctness. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Test Changes0 test added, 0 removed Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Fixes an issue where
questTimelineChartwas not properly bucketizing unaligned timestamp intervals.PR created automatically by Jules for task 14729035637876417102 started by @KCarretto