-
Notifications
You must be signed in to change notification settings - Fork 3
protocol 1.6: minimal update to get broadcast_package out #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8e26c35
add new protocol version 1.6
SomberNight b774837
add submitpackage methods
0466646
add note about estimatefee caching
SomberNight 7b84d2a
add new method: mempool.get_info, and rm redundant relayfee method
SomberNight 9657730
broadcast_package RPC: add notes about bitcoind version differences
SomberNight a4f158c
readthedocs: update version str
SomberNight e54c0e4
server.version: server must ignore extraneous args, to allow future ext
SomberNight b269a8f
broadcast_package RPC: explicitly state verbose=true is not stable
SomberNight 919df4f
scripthash status calculation: add a detailed example
SomberNight c617d4d
broadcast_package RPC: note JSON RPC ERROR vs success=false+errors_arr
SomberNight 394a8fd
scripthash status calc: invert order of mempool txs
SomberNight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| Protocol Changes | ||
| ================ | ||
|
|
||
| This documents lists changes made by protocol version. | ||
| This document lists changes made by protocol version. | ||
|
|
||
| Version 1.0 | ||
| =========== | ||
|
|
@@ -175,3 +175,44 @@ New methods | |
| ----------- | ||
|
|
||
| * :func:`blockchain.name.get_value_proof` to resolve a name (with proof). Name index coins (e.g. Namecoin) only. | ||
|
|
||
|
|
||
| Version 1.5 | ||
| =========== | ||
|
|
||
| (this version number was skipped, no corresponding protocol is defined) | ||
|
|
||
|
|
||
| .. _version 1.6: | ||
|
|
||
| Version 1.6 | ||
| =========== | ||
|
|
||
| Changes | ||
| ------- | ||
|
|
||
| * Breaking change for the version negotiation: we now mandate that | ||
| the :func:`server.version` message must be the first message sent. | ||
| That is, version negotiation must happen before any other messages. | ||
| * Also for :func:`server.version`, the server must tolerate and ignore | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is stupid. Again, this is what the features map is for. But whatever. |
||
| extraneous arguments, to allow for extensions in future protocol versions. | ||
| * The status of a scripthash has its definition tightened in a | ||
| backwards-compatible way: mempool txs now have a canonical ordering | ||
| defined for the calculation (previously their order was undefined). | ||
| * :func:`blockchain.scripthash.get_mempool` previously did not define | ||
| an order for mempool transactions. We now mandate a specific ordering. | ||
| * Optional *mode* argument added to :func:`blockchain.estimatefee`. | ||
| * :func:`blockchain.block.headers` now returns headers as a list, | ||
| instead of a single concatenated hex string. | ||
|
|
||
| New methods | ||
| ----------- | ||
|
|
||
| * :func:`blockchain.transaction.broadcast_package` to broadcast a package of transactions (submitpackage). | ||
| * :func:`mempool.get_info` to get more detailed and general relayfee info. | ||
|
|
||
| Removed methods | ||
| --------------- | ||
|
|
||
| * :func:`blockchain.relayfee` is removed. The `minrelaytxfee` field | ||
| of the new :func:`mempool.get_info` RPC is a direct replacement. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I skipped 1.5.x as Fulcrum and https://github.com/cculianu/electrum-cash-protocol uses these version numbers.
However I now realise this is nevertheless somewhat problematic:
if a client wants to support protocol version 1.4 and 1.6 but not 1.5.x, they are in quite a pickle.
If the client sends
server.version("electrum/4.6.2", ["1.4", "1.6"])to Fulcrum 2.0, the server will select protocol version 1.5.x.By design of
server.version, clients must support a continuous range of versions.OTOH, servers are free to pick-and-choose any particular protocol version they want and can skip interim versions.
From a quick read of "electrum-cash-protocol", I think all the changes in the interim versions are backwards compatible. So maybe this is all ~fine... Nevertheless, the situation is unfortunate.