Elimination of duplication through common logic #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi! Just following up to see if there's anything I can improve in this PR 🙇 |
|
Hi maintainers 👋 |
ccoVeille
reviewed
Jul 29, 2025
flag_groups.go
Outdated
| processFlagForGroupAnnotation(flags, pflag, oneRequiredAnnotation, oneRequiredGroupStatus) | ||
| processFlagForGroupAnnotation(flags, pflag, mutuallyExclusiveAnnotation, mutuallyExclusiveGroupStatus) | ||
| }) | ||
| required, oneRequired, mutuallyExclusive := c.getFlagGroupStatuses() |
There was a problem hiding this comment.
Usually when I see a function returning 3 values, I tend to recommend returning a struct with 3 fields. It often helps because more values can be returned easily, also you don't always need all values depending on where you call the function
|
Thank you for your feedback! I’ve updated the function to return a struct in order to make it clearer and more extensible.
|
ccoVeille
reviewed
Aug 1, 2025
|
Thank you for your feedback! |
ccoVeille
approved these changes
Aug 3, 2025
jharshman
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Both the
ValidateFlagGroupsandenforceFlagGroupsForCompletionfunctions currently contain duplicated logic for determining which flags have been set in each flag group.Fix
This redundancy has been eliminated by extracting the shared logic into a helper function named
getFlagGroupStatuses, improving maintainability and making future changes easier.