Skip to content

Conversation

@andig
Copy link
Contributor

@andig andig commented Mar 8, 2020

Replace #509. Fixes #171, #504, #800.

@CLAassistant
Copy link

CLAassistant commented Mar 8, 2020

CLA assistant check
All committers have signed the CLA.

@andig
Copy link
Contributor Author

andig commented Mar 8, 2020

@sagikazarmark I realize there is a big number of open PRs. Is this one you'd consider given it addresses a number of open issues?

@andig
Copy link
Contributor Author

andig commented Mar 17, 2020

ping gentle nudge @sagikazarmark any chance to get your review?

@andig
Copy link
Contributor Author

andig commented Mar 23, 2020

I'm also watching #866. In case that gets merged I'll check if it makes sense to carry the flag assignment over.

@sagikazarmark
Copy link
Collaborator

Sorry @andig , my hands are full right now. I'll take a look at your PR when I get the chance,

@criscola
Copy link

I would be interested in having this...

@ben-turner
Copy link

I usually try to avoid "bump" and "+1" comments, but this seems like a fairly straight-forward PR that provides a lot of value, so I just wanted to bump it up to the top of the list before it gets lost to time.

@andig
Copy link
Contributor Author

andig commented Jan 14, 2026

Fixed the merge conflict while we're approaching 6th birthday of this PR. I can't even remember why I've added this. Is there still demand? Otherwise I'd like to close here ;)

@andig
Copy link
Contributor Author

andig commented Jan 14, 2026

Actually, all issues have been closed as "not planned". Closing here. Sorry for the noise.

@andig andig closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

viper.Sub() fails when the subtree is an array

5 participants