Url regexp #43
Open
Url regexp #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepiercy
requested changes
Jan 14, 2026
Comment on lines
+791
to
+795
| Filters urls by matching based on a regexp instance built based | ||
| on the regular expression passed here as a string. The ones not matching | ||
| are discarded. | ||
|
|
||
| .. versionadded:: 1.8.1 |
Collaborator
There was a problem hiding this comment.
I think this is more clear to the reader.
Suggested change
| Filters urls by matching based on a regexp instance built based | |
| on the regular expression passed here as a string. The ones not matching | |
| are discarded. | |
| .. versionadded:: 1.8.1 | |
| Filters URLs by matching a regular expression passed into the parameter ``url_regexp`` as a string. | |
| The URLs that don't match get discarded. | |
| .. versionadded:: 2.0.0 |
Collaborator
|
@mbenedettini thank you for creating this PR. To merge this, would you please:
Then I'll review and merge. It looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New string flag:
url_regexpFilters urls by matching based on a regexp instance built based on the regular expression passed here as a string. The ones not matching are discarded.