normalize pyproject, PEP-621 compliant#24
Open
mgaitan wants to merge 1 commit intosphinx-contrib:masterfrom
Open
normalize pyproject, PEP-621 compliant#24mgaitan wants to merge 1 commit intosphinx-contrib:masterfrom
mgaitan wants to merge 1 commit intosphinx-contrib:masterfrom
Conversation
mgaitan
commented
May 30, 2024
| dependencies = [ | ||
| "sphinx", | ||
| "requests>=2.4.2", | ||
| "pyyaml", |
Author
There was a problem hiding this comment.
added this because wasn't declared as dep
danieleades
suggested changes
Sep 26, 2024
|
|
||
| [tool.black] | ||
| line-length = 79 | ||
| target-version = ["py38"] |
There was a problem hiding this comment.
this isn't required, black will infer it from the requires-python value
see https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#t-target-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
setup.pyand keep onlypyproject.tomlin a PEP-621 compliance format, using flit to build . The description adn version are declared explicitly in__init__.pymodule and loaded dynamically for the package.This fixes "No module named 'pkg_resources'" when setuptools is not available.