Open
Conversation
hugovk
reviewed
Jul 21, 2023
AA-Turner
reviewed
Jul 22, 2023
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Collaborator
Author
|
With the "better" detection of tables I had to remove a test that was passing by chance: the test was ensuring we were finding errors in a table... and the table used in the test was so small it went undetected by the old check, so we were looking for errors in it. With the current detection of table we correctly identify the table as a table and stop searching in it. |
5 tasks
Borda
reviewed
Mar 8, 2024
Contributor
There was a problem hiding this comment.
Btw, if tox is added, shall also be used in CI so we keep them aligned?
Collaborator
There was a problem hiding this comment.
Done in #100.
There's some non-tox things added in this PR. If they're still needed, should this PR be rebased. or this closed and those bits split out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.