Skip to content

Conversation

@RobertoRoos
Copy link
Collaborator

@RobertoRoos RobertoRoos commented Nov 27, 2025

Duplicate or renewed version of

I don't think I can push directly in @mikemckiernan 's branch and even if I can not sure I should. So I figured I would have my own PR here.
Of course we could also rebase this branch from my fork into the original feature branch: https://github.com/mikemckiernan/sphinx-argparse/tree/add-domain

Todo:

  • So far I have only renamed the conf options. Tests haven't been altered yet and will still all fail -> Fix tests

mikemckiernan and others added 6 commits August 19, 2024 19:44
- Print fully-qualified subcommand name in title

- Support commands:command role for intersphinx

- Prefer fully-qualified HREF targets

  Use targets like "#blah-sub-commands" as
  the primary target and move historic targets
  like "#Sub-commands" to secondary targets.

  Preserve the older HREF, `sub-commands`, as a
  secondary target. In the HTML, this becomes a span
  just below the section element so that bookmarks continue
  to work even after adopting the update from this commit.
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
@RobertoRoos RobertoRoos marked this pull request as draft November 27, 2025 10:19
mikemckiernan and others added 3 commits December 2, 2025 12:21
Previously, the xpaths checked the TOC navigation
for the expected pages. With this update,
the xpaths check for the expected pages in the
toctree-generated navigation on the document div.

Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
@RobertoRoos RobertoRoos marked this pull request as ready for review December 2, 2025 11:36
@RobertoRoos
Copy link
Collaborator Author

RobertoRoos commented Dec 2, 2025

I think this is ready, but merging will be easier after merging #84 and #79

@mikemckiernan
Copy link

Thanks for dusting this off and fixing it up!

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 78.93258% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.94%. Comparing base (fa28a38) to head (e14990e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
sphinxarg/ext.py 76.47% 42 Missing and 14 partials ⚠️
test/utils/xpath.py 58.33% 6 Missing and 4 partials ⚠️
sphinxarg/utils.py 58.82% 4 Missing and 3 partials ⚠️
test/test_argparse_directive.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   47.18%   51.94%   +4.75%     
==========================================
  Files          12       18       +6     
  Lines         960     1286     +326     
  Branches      206      261      +55     
==========================================
+ Hits          453      668     +215     
- Misses        467      575     +108     
- Partials       40       43       +3     
Flag Coverage Δ
unittests 51.71% <78.65%> (+4.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobertoRoos
Copy link
Collaborator Author

I failed to rebase this branch onto origin/main property, so I committed a sin by merging in main instead. I'd recommend we just squash-merge this branch to tidy it up.

@ashb what do you think about this? Should we merge the other PRs made by me first? Anything I can do?

RobertoRoos added a commit that referenced this pull request Jan 20, 2026
@RobertoRoos
Copy link
Collaborator Author

RobertoRoos commented Jan 20, 2026

Got squash committed in 4564fdd !

Annoying that Github didn't pick up on it, closing this PR manually instead.

@RobertoRoos RobertoRoos deleted the add-domain-rebase-2025 branch January 20, 2026 18:05
@RobertoRoos RobertoRoos mentioned this pull request Jan 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants