-
-
Notifications
You must be signed in to change notification settings - Fork 28
Refactor the extension to use a Sphinx Domain (Updated in 2025) #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Print fully-qualified subcommand name in title - Support commands:command role for intersphinx - Prefer fully-qualified HREF targets Use targets like "#blah-sub-commands" as the primary target and move historic targets like "#Sub-commands" to secondary targets. Preserve the older HREF, `sub-commands`, as a secondary target. In the HTML, this becomes a span just below the section element so that bookmarks continue to work even after adopting the update from this commit.
Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
Previously, the xpaths checked the TOC navigation for the expected pages. With this update, the xpaths check for the expected pages in the toctree-generated navigation on the document div. Signed-off-by: Mike McKiernan <mmckiernan@nvidia.com>
|
Thanks for dusting this off and fixing it up! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 47.18% 51.94% +4.75%
==========================================
Files 12 18 +6
Lines 960 1286 +326
Branches 206 261 +55
==========================================
+ Hits 453 668 +215
- Misses 467 575 +108
- Partials 40 43 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I failed to rebase this branch onto @ashb what do you think about this? Should we merge the other PRs made by me first? Anything I can do? |
|
Got squash committed in 4564fdd ! Annoying that Github didn't pick up on it, closing this PR manually instead. |
Duplicate or renewed version of
I don't think I can push directly in @mikemckiernan 's branch and even if I can not sure I should. So I figured I would have my own PR here.
Of course we could also rebase this branch from my fork into the original feature branch: https://github.com/mikemckiernan/sphinx-argparse/tree/add-domain
Todo: