Remove redundant static typing casts #10612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
refactor/redundant-cast
branch
from
8ba17c5 to
d3f0164
Compare
Contributor
Author
|
i don't believe the CI failure is to do with this PR |
tk0miya
reviewed
Jul 2, 2022
| check_untyped_defs = True | ||
| warn_unused_ignores = True | ||
| strict_optional = False | ||
| no_implicit_optional = True |
|
|
||
| def apply(self, **kwargs: Any) -> None: | ||
| for node in self.document.findall(AliasNode): | ||
| node = cast(AliasNode, node) |
Member
There was a problem hiding this comment.
Good point. Our stubs surely provide nice annotation for findall()!
https://github.com/tk0miya/docutils-stubs/blob/b14071d065f8ee35399856fcaff6cd608294a342/docutils-stubs/nodes.pyi#L32-L33
Member
|
I manually re-run failed tests :-) |
AA-Turner
reviewed
Jul 2, 2022
AA-Turner
approved these changes
Jul 2, 2022
Member
|
Thanks Dan! A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redundant
typing.casts and updates mypy config to prevent these in future.type casts should only be used as a last resort, as they can mask errors if refactoring later changes the type of an object.