Add tox lint target
#11602
Merged
Add tox lint target
#11602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Aug 16, 2023
Closed
Contributor
Author
|
#11603 is a superior option that minimises duplication all around. Let's go with that approach. |
Most likely because it can be a lot of extra work and maintainers didn't prioritize it. However, it would improve code quality.
Absolutely worth it even if you have to use |
'isolated_build' is no longer required since builds are isolated by default in tox 4. 'basepython' is no longer required since tox 4 only supports Python 3 and 'basepython' defaults to the version of Python that tox is installed with. Signed-off-by: Stephen Finucane <[email protected]>
This simply runs the same commands as the GitHub CI workflows. Signed-off-by: Stephen Finucane <[email protected]>
stephenfin
force-pushed
the
readd-tox-integration
branch
from
4b12fb8 to
7da84e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Refactoring
Purpose
Re-add a tox environment for linters. This environment uses the 'lint' extras
and runs the same commands as the GitHub Workflows. A note is added reminding
people to keep the two in-sync.
Detail
This resolves #11599. There is an (arguably superior but more involved) alternative at #11603.
Relates
(none)