Skip to content

test_build_html: test_html_scaled_image_link: allow newlines between HTML img and anchors #11863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2024
Merged

test_build_html: test_html_scaled_image_link: allow newlines between HTML img and anchors #11863

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb06990
test_build_html: test_html_scaled_image_link: allow newlines between …
jayaddison Jan 9, 2024
b49fdf2
test_build_html: test_html_scaled_image_link: nitpick: allow zero-or-…
jayaddison Jan 9, 2024
495e26d
test_build_html: add explanatory comment about docutils 0.21 newline …
jayaddison Jan 9, 2024
f6154ee
test_build_html: test_html_scaled_image_link: conditionally check for…
jayaddison Jan 9, 2024
edb19b8
Merge branch 'master' into issue-11862/test-build-html-docutils-newli…
jayaddison Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_build_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from pathlib import Path
from unittest.mock import ANY, call, patch

import docutils
import pytest
from html5lib import HTMLParser

Expand Down Expand Up @@ -1645,8 +1646,11 @@ def test_html_scaled_image_link(app):
assert re.search('\n<img alt="_images/img.png" src="_images/img.png" />', context)

# scaled_image_link
# Docutils 0.21 adds a newline before the closing </a> tag
closing_space = "\n" if docutils.__version_info__[:2] >= (0, 21) else ""
assert re.search('\n<a class="reference internal image-reference" href="_images/img.png">'
'<img alt="_images/img.png" src="_images/img.png" style="[^"]+" /></a>',
'<img alt="_images/img.png" src="_images/img.png" style="[^"]+" />'
f'{closing_space}</a>',
context)

# no-scaled-link class disables the feature
Expand Down