-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Static templates: also support .jinja files
#11916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static templates: also support .jinja files
#11916
Conversation
…ontents of a legacy-suffix template
…fix template detection on case-sensitive filesystems
… on separate line
…es to '_t'-suffix templates
|
Can we split adding support for |
That seems reasonable, yep. I've restored the original template file paths in this branch. This could be a case where I'd consider rebasing the commits here. It doesn't seem to make a practical difference given that the changes will be squashed, but somehow it feels odd to have two changes that combine into a no-op in a merged PR. |
…references to '_t'-suffix templates" This reverts commit ca21989.
…mended-suffix, providing a forwards-compatibility test
|
Definitely agree with this by the way, I was just thinking the other day that I wanted these templates to be compatible with https://marketplace.visualstudio.com/items?itemName=samuelcolvin.jinjahtml |
.jinja files
Some filesystems, such as APFS, use case-sensitive filenames, but require files to be named distinctly in a case-insensitive manner. Without using case-insensitive filename comparison, we risk the possibility that, for example, someone using Linux/Windows could create a template file that works fine on their machine, but that fails when someone else tries to build that project on MacOS.
|
Thank you @AA-Turner! |
Feature or Bugfix
Purpose
.jinjaextension for templates.coveragepythat can cause warnings to be emitted when non-Python files are treated as potentially containing Python bytecode for coverage evaluation (ref [low-prio] Possible bug: files without extensions misidentified as Python? coveragepy/coveragepy#1488).Detail
_tsuffix or secondly for the additionally-supported.jinjasuffix.Relates
.jinjato_tfor static templates #11165 - this time without deprecation notices or a deprecation schedule.