Skip to content

Conversation

@Lynn-Hu-D
Copy link
Contributor

Subject: Provide a better error message if the master document is not included in project documents [#11873]

Feature or Bugfix

  • Bugfix
  • Refactoring

Purpose

  • Provide a better error message if the master document is not included in project documents

Detail

Three cases if the master document (index.rst) is not found.

  • Case 1: The master document is included in the exclude_patterns
  • Case 2: The include_patterns is set, but the master document is not included in the include_patterns
  • Case 3: The master document does not exist in the project t document.

Relates

@picnixz
Copy link
Member

picnixz commented Feb 26, 2024

Please add some tests (or I'll do it myself this w-e since this might be a bit difficult) and a CHANGES entry.

@picnixz
Copy link
Member

picnixz commented Mar 4, 2024

Sorry, I totally forgot about that PR and since I am travelling I won't be able to add the tests. I'll do it in 10 days or so but thank you for your work for now!

@picnixz picnixz self-requested a review March 4, 2024 09:00
@Lynn-Hu-D
Copy link
Contributor Author

Sorry, I totally forgot about that PR and since I am travelling I won't be able to add the tests. I'll do it in 10 days or so but thank you for your work for now!

@Lynn-Hu-D
Copy link
Contributor Author

Hello,
I didn't intend to close the issue; it was an accident. What steps should I take now to have this PR merged?

@picnixz picnixz reopened this Mar 28, 2024
@picnixz
Copy link
Member

picnixz commented Mar 28, 2024

I didn't intend to close the issue; it was an accident. What steps should I take now to have this PR merged?

You should add a test for that. Do you want some help? (I will be busy until... the end of the week but ping me next week if I forgot about it).

@AA-Turner AA-Turner merged commit f0d8e2e into sphinx-doc:master Jul 14, 2024
@AA-Turner AA-Turner added this to the 7.4.0 milestone Jul 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants