Skip to content

Improve error message for import exception group #14057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Improve error message for import exception group #14057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx/ext/autosummary/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@
exceptions: list[BaseException] = functools.reduce(
operator.iadd, (e.exceptions for e in errors), []
)
raise ImportExceptionGroup('no module named %s' % ' or '.join(tried), exceptions)
raise ImportExceptionGroup(f'could not import {" or ".join(tried)}', exceptions)

Check failure on line 687 in sphinx/ext/autosummary/__init__.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (EM102) 

sphinx/ext/autosummary/__init__.py:687:32: EM102 Exception must not use an f-string literal, assign to variable first

Check failure on line 687 in sphinx/ext/autosummary/__init__.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (TRY003) 

sphinx/ext/autosummary/__init__.py:687:11: TRY003 Avoid specifying long messages outside the exception class


def _import_by_name(name: str, grouped_exception: bool = True) -> tuple[Any, Any, str]:
Expand Down
Loading