Skip to content

Skip when building embedded HTML #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Skip when building embedded HTML #137

wants to merge 2 commits into from

Conversation

methane
Copy link

@methane methane commented May 16, 2025

fix #136

@m-aciek m-aciek mentioned this pull request May 16, 2025
Closed
m-aciek
m-aciek approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@m-aciek m-aciek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it is causing the Open Graph tags to not render in EPUB build of the Python documentation. Thank you! Should we document this behavior?

Test failure seems unrelated.

@m-aciek
Copy link
Contributor

m-aciek commented Jun 13, 2025

The test failure is fixed in #138. This PR would fix EPUB builds of Python documentation. Could you please have a look? @TheTripleV @Daltz333 @AA-Turner

Thank you!

@TheTripleV
Copy link
Collaborator

I don't have push perms to the new main branch so @AA-Turner will have to merge

@m-aciek m-aciek mentioned this pull request Jun 30, 2025
Open
@m-aciek m-aciek mentioned this pull request Jul 10, 2025
Closed
@hugovk hugovk mentioned this pull request Jul 11, 2025
Merged
@m-aciek
Copy link
Contributor

m-aciek commented Jul 11, 2025

@TheTripleV Adam claims you have the permissions. Would you be able to double check? Thank you!

@AA-Turner AA-Turner changed the title skip when building embedded html Skip when building embedded HTML Aug 3, 2025
AA-Turner
AA-Turner reviewed Aug 3, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@methane @m-aciek is there a simple test we could have here?

A

@AA-Turner AA-Turner deleted the branch sphinx-doc:0.x August 29, 2025 12:22
@AA-Turner AA-Turner closed this Aug 29, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@TheTripleV TheTripleV TheTripleV approved these changes

+1 more reviewer

@m-aciek m-aciek m-aciek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom tags and EPUB builder
4 participants
@methane @m-aciek @TheTripleV @AA-Turner