Skip to content

Conversation

@cmarqu
Copy link
Contributor

@cmarqu cmarqu commented Jul 27, 2025

(This PR is based on/includes #179.)

The recently merged #157 adds all_in_one_restructuredtext.py which needs the napoleon extension for some of its docstrings, but I had forgotten to include it in that PR (I don't have a setup where I can completely build the project locally).

@cmarqu
Copy link
Contributor Author

cmarqu commented Jul 29, 2025

Rebased to the updated #179.

@shirou
Copy link
Contributor

shirou commented Jul 30, 2025

@cmarqu Since I have merged #179, could you rebase on master branch?

@cmarqu cmarqu force-pushed the fix/add-napoleon branch from 2ac582f to ac2ce36 Compare July 30, 2025 09:33
@cmarqu
Copy link
Contributor Author

cmarqu commented Jul 30, 2025

@cmarqu Since I have merged #179, could you rebase on master branch?

Done.

Copy link
Contributor

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shirou shirou merged commit eccec1c into sphinx-themes:master Jul 30, 2025
2 checks passed
@stevepiercy
Copy link
Contributor

Thanks for all your work on this.

I might maintain one of only three projects I know that pull in the Kitchen Sink files, the other being PyData Sphinx Theme and Sphinx Book Theme.

Ping @choldgraf and @drammock in case they want to update their update_kitchen_sink.py scripts and conf.pys to render the new beautiful API docs.

See also:

@cmarqu
Copy link
Contributor Author

cmarqu commented Aug 1, 2025

I have just opened a draft PR for some smaller fixes in #182 that you may want to wait on.

@stevepiercy
Copy link
Contributor

Not a problem for me. I run the Python script that pulls in changes to all the Kitchen Sink files, commit, push, open a PR, and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants