Improve IcebergCommitExec to correctly populate properties schema #22
+5
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR fixes schema mismatch errors when using
IcebergCommitExec
. Below is example DataFusion DataSinkExec implementation demonstrating that properties must be created based on target schema, not input.https://github.com/apache/datafusion/blob/4eacb6046773b759dae0b3d801fe8cb1c6b65c0f/datafusion/datasource/src/sink.rs#L101C1-L117C6
Note: I was not able to quickly identify the difference between the initial use case—when IcebergCommitExec is the top plan node and it does not fail - and the case where an additional node is added to invalidate the cache after a write and I see errors. I suspect this behavior is due to DataFusion optimizations or verifications to ensure that inputs are correct and compatible. This fixes the following error
What changes are included in this PR?
Are these changes tested?