fix: prevent DataFusion RepartitionExec insertion into IcebergCommitExec #23
+117
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR adds
required_input_distribution
setting forIcebergWriteExec
to ensure DataFusion coalesces input partitions automatically before commit, fixing partitioning issues in Iceberg write operations (partial writes). Closes spiceai/spiceai#7407Despite the following code, w/o proper
IcebergWriteExec
settings DF optimizer rewrites this resulting in the following physical plan as a result sometimes only first partition is handled.https://github.com/spiceai/iceberg-rust/blob/spiceai-0.7.0-rc1/crates/integrations/datafusion/src/table/mod.rs#L212-L225
After
What changes are included in this PR?
Are these changes tested?