Skip to content

Conversation

@Bossiskeyboard
Copy link
Contributor

@Bossiskeyboard Bossiskeyboard commented Dec 15, 2025

Adds /usr/share/spotify-client to the list of Spotify installation search paths. This allows for the detection of the lpf-spotify-client package commonly used on Fedora Linux.

Summary by CodeRabbit

  • Bug Fixes
    • Improved Spotify client detection on Linux by expanding the locations scanned for installations to include an additional common path variant, increasing detection reliability across setups.

✏️ Tip: You can customize this high-level summary in your review settings.

Adds /usr/share/spotify-client to the list of Spotify installation search paths. This allows for the detection of the lpf-spotify-client package commonly used on Fedora Linux.
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

Updated the Linux application candidate list in src/utils/config.go to add the path /usr/share/spotify-client/ while leaving the existing /usr/share/spotify-client entry unchanged. No other logic or public signatures were modified.

Changes

Cohort / File(s) Summary
Configuration enhancement
src/utils/config.go
Added new candidate Linux path /usr/share/spotify-client/ to the linuxApp search list for Spotify client discovery; the existing /usr/share/spotify-client entry remains present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line addition to a configuration path list with no logic changes or side effects

Poem

🐰 A path through the Linux lands so wide,
Where Spotify clients may hide and reside,
One slash more to wander, one route to explore,
The rabbit hops lightly and checks one path more! 🎵

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references 'lpf-spotify-client' path which aligns with the PR's objective of adding /usr/share/spotify-client to support Fedora's lpf-spotify-client package, accurately reflecting the main change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/utils/config.go (1)

310-310: Add trailing slash for consistency with other paths.

The path /usr/share/spotify-client is correct for lpf-spotify-client on Fedora. However, for style consistency with all other entries in potentialList, add a trailing slash:

-		"/usr/share/spotify-client",
+		"/usr/share/spotify-client/",

The validation logic uses filepath.Join() which normalizes paths correctly regardless of the trailing slash, so this is a cosmetic improvement with no functional impact.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23db696 and 8763eff.

📒 Files selected for processing (1)
  • src/utils/config.go (1 hunks)

@rxri rxri changed the title feat(linux): Add lpf-spotify-client path for Fedora feat(config/linux): add lpf-spotify-client path Dec 15, 2025
@rxri rxri merged commit a5a7436 into spicetify:main Dec 15, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants