feat: add another downloader

[rxri]

Summary by CodeRabbit

• Chores
  • Updated configuration data with new repository entries and pattern allowances to maintain current data standards.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4488c2c and efd9eaa.

📒 Files selected for processing (1)

• resources/blacklist.json

---

Walkthrough

The change adds a blacklist entry for a specific Spicetify downloader repository and introduces a wildcard pattern to prevent any repositories under the associated organization from being used.

Changes

Cohort / File(s)	Summary
Blacklist Configuration resources/blacklist.json	Adds "https://github.com/diorhc/Spicetify-Downloader" to the repos array and "https://github.com/diorhc/*" to the bl syntax patterns for wildcard matching.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• feat(blacklist): add another downloader #1107: Both PRs modify resources/blacklist.json to add downloader-related repository entries and corresponding wildcard patterns.
• feat(blacklist): add complex-lyrics #1085: Both PRs modify resources/blacklist.json and add new blacklist entries to the repos and wildcard bl-syntax arrays.
• feat: update blacklist #1083: Both PRs modify resources/blacklist.json by adding new repository entries to the blacklist.

Suggested reviewers

• theRealPadster
• kyrie25

Poem

🐰 A hop and a skip through the blacklist we go,
Adding entries where blocklisted repos should not show,
Wildcards and patterns, oh what a sight!
Keeping the marketplace safe and right ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rxri-patch-1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[aazz180]

Hi sorry, I'm confused on why do you purposely block spotify offline music downloaders? You allow adblockers so I assume its not because you have a grudge against people pirating/bypassing Spotify's premium features? If possible, could you please give me a reason? thanks @rxri

[aazz180]

If theres a TOS requirment / rule in this repo, can you please link to it. Thanks

[theRealPadster]

Downloading music files locally to use outside of Spotify is not even a premium feature, it's something you're not allowed to do period.

[aazz180]

Downloading music files locally to use outside of Spotify is not even a premium feature, it's something you're not allowed to do period.

Okay, but why do you disallow via filtering from anyone that is using the Spicetify Marketplace, isn't that Github/Spotify's lawyers job, it doesn't affect this repo if you don't add it to the marketplace. I just don't understand the logic behind this PR.

Aren't you using more of the user's resources to check and block it, and the marketplace is opensource, so it's easy to bypass.

[theRealPadster]

Okay, but why do you disallow via filtering from anyone that is using the Spicetify Marketplace, isn't that Github/Spotify's lawyers job, it doesn't affect this repo if you don't add it to the marketplace. I just don't understand the logic.

Because we don't want to give them any reason/excuse to take down the marketplace or Spicetify. If someone uploads a downloader that makes use of Spicetify, that's one thing, but we would rather not have it show up for easy install in the marketplace, so it doesn't look like we're facilitating or condoning piracy.

[aazz180]

Okay, but why do you disallow via filtering from anyone that is using the Spicetify Marketplace, isn't that Github/Spotify's lawyers job, it doesn't affect this repo if you don't add it to the marketplace. I just don't understand the logic.

Because we don't want to give them any reason to take down the marketplace or Spicetify. If someone uploads a downloader that makes the use of Spicetify, that's one thing, but we would rather not have it show up for easy install in the marketplace.

Nevermind, I understand I misread the code. Thanks,

[theRealPadster]

But that's not what this PR is doing, this isn't adding it to the marketplace - this downloader just makes uses of spicetify and this PR isn't adding its functionality to the market place. Your adding it to a blacklist of plugins that is disallowed? I understand malicious plugins, but why this.

Because to non-techy people (i.e. a lot of business/lawyer people), having it show up in the marketplace could make it look like we're facilitating or condoning piracy. End of discussion.