Conversation
… audit logging, and improved UI
stakach
requested changes
Jan 12, 2026
Member
There was a problem hiding this comment.
Looking great!
@naqvis I would obscure the password reset token in the database.
Similar to what we do here:
https://github.com/PlaceOS/models/blob/master/src/placeos-models/api_key.cr#L59
That will improve security significantly - bcrypt like we do for the users password is probably more secure again
What do you think?
Contributor
Author
|
Good call! 👍 I'll implement this following the API key pattern with HMAC-SHA512:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features
User Groups
Password Reset
/auth/forgot-passwordand/auth/reset-passwordpagesEmail Notifications
API Key Authentication
Authorization: Bearer sk_...)Audit Logging
Health Check Endpoints
GET /health- Basic health statusGET /health/live- Liveness probeGET /health/ready- Readiness probe (checks database)User Profile Page
/profileUI Improvements
Technical Changes
emailshard for SMTP supportgroups,group_users,group_invitesaudit_logs,api_keys,password_reset_tokensLinkheaders andX-Total-Count