main: substitute: skip inputs with different origins#15
Open
main: substitute: skip inputs with different origins#15
Conversation
This sample adds a flake which contains an input with the name "tokyonight" where it has a transitive input also called "tokyonight". This is triggering an uncaught infinite recursion and overflowing the stack.
This new option can be specified for many input names. The names used in this option's values will not be subject to skipping if the transitive input of the same name is from a different branch. Prior to #15 (a fix for #14) the default behavior was to ignore the `original` attribute of the locked input, meaning that input substitutions were performed by-name only, and did not take into account that some dependencies may add inputs with the same name as exist in the root node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert that transitive inputs will not be substituted with those from the root flake unless they are from the same origin/remote resource.
This closes #14.