Draft
Conversation
- removed `node_state_indices ` (as this resolution is always a subset of `node_injection_indices` - removing to_node/from_node and replace with unit_flow indices (toDO: add this to preprocessing) - TODO: set-template values to `null`
- problem could be related to the implementation of `direction`
Tests should now be passing (previously wrong order of object classes)
Collaborator
Author
|
Tests are passing now (for julia 1.6, as julia 1.2 seems no longer supported because of @Spawn). |
manuelma
changed the title
Member
|
The aim of this PR is to fix to ensure that resolution is the one that is expected. Check the current state in the main branch and see if it makes sense for the changes in #1119 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_state_indices(as this resolution is always a subset ofnode_injection_indicesnull