node-installer: add integration test and add special handlings for k3s #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce a script to integration test the node-installer image - add a KWasm node installer job file for the integration test - modified the README to include instructions for building the image locally and running the integration tests Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
requested review from
devigned,
jsturtevant,
kate-goldenring and
radu-matei
as code owners
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
node-installer-integration-test
branch
from
fe71828 to
aca6e02
Compare
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
This includes integration tests for Kind, MiniKube, MicroK8s, and K3s. Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
node-installer-integration-test
branch
from
e50bf66 to
63badf2
Compare
Mossaka
force-pushed
the
node-installer-integration-test
branch
from
1415aa2 to
a9b0f86
Compare
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Mossaka
force-pushed
the
node-installer-integration-test
branch
from
a9b0f86 to
c68b1c2
Compare
Mossaka
changed the title
kate-goldenring
approved these changes
Mar 20, 2025
Collaborator
kate-goldenring
left a comment
kate-goldenring
left a comment
There was a problem hiding this comment.
LGTM! I added a few clean up pointers that would be great to address but could also be done in a follow up
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
- move the testing scripts to the `node-installer/tests/` directory - move the kwasm-job.yml to the `node-installer/tests/workloads/` directory - symlink the workload.yaml and runtime.yaml from the root `deployments/workloads/` to the `node-installer/tests/workloads/` directory Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxiao (mossaka) Zhou [email protected]