Add helm chart #204
Merged
Add helm chart #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
…ame and handler Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
adamreese
reviewed
Sep 19, 2024
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
11 tasks
voigt
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Helm chart looks good to me. Runs well on my local KIND.
Unfortunately, we don't have automated tests in place for the different k8s variants. So I suggest tracking issues with other k8s variants as bugs and fixing them as they occur.
For now we should treat the chart as "beta" and do the testing before we officially release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a Helm chart, building off of #132 where the bulk of the work was done.
With @voigt's blessing I have created a new PR with a handful of fixes and changes (see commit history). Testing has shown the runtime-class-manager to work properly on kind and AKS clusters.
Issue ticket number and link
#47
Checklist before requesting a review