Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Sep 26, 2024

Describe your changes

  • Bumps controller-tools to the latest v0.16.3 release

  • Includes controller-gen updates to a few files in config

    • These seem to be fairly innocuous, but could use a close look
    • Includes some description re-formatting and re-wording and RBAC consolidation

Note: I'm not yet able to fully test via the make build deploy flow as RBAC issues remain.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@voigt
Copy link
Member

voigt commented Oct 27, 2024

@vdice would you like to fix the merge conflict?
Apart from that PR LGTM.

@vdice vdice force-pushed the ref/bump-controller-gen branch from fab3598 to f6e223f Compare October 28, 2024 17:25
@vdice
Copy link
Collaborator Author

vdice commented Oct 28, 2024

Rebased; thanks @voigt!

@vdice vdice requested a review from voigt October 28, 2024 18:06
@voigt voigt merged commit 51e5266 into spinframework:main Oct 29, 2024
8 checks passed
@vdice vdice deleted the ref/bump-controller-gen branch October 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants