Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Oct 22, 2024

Describe your changes

Addresses some Dockerfile warnings seen locally and also in GitHub eg in https://github.com/spinkube/runtime-class-manager/pull/234/files under the 'Unchanged files with check annotations' section.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice requested a review from voigt October 23, 2024 22:58
Copy link
Collaborator

@phyrog phyrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phyrog phyrog merged commit b733b93 into spinframework:main Oct 25, 2024
5 checks passed
@vdice vdice deleted the chore/address-dockerfile-warnings branch October 25, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants