Distro detection parity with containerd-shim-spin's installer #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
autodetect-pr-84-updates
branch
from
5fe2448 to
6a35df1
Compare
vdice
force-pushed
the
autodetect-pr-84-updates
branch
2 times, most recently
from
84b34c3 to
33f96a6
Compare
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
autodetect-pr-84-updates
branch
from
33f96a6 to
0703753
Compare
voigt
approved these changes
Oct 27, 2024
phyrog
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds distro detection for parity with the current installer script used in SpinKube today (see containerd-shim-spin's installer script)
Incorporates changes from #84 and adds the following additional commits:
Notes
I used Lima VMs to test the following distros (links to their lima.yaml configs):
For all of these, I used the quick start/easy mode for installation.
Untested and looking for volunteers to help out: GKE, EKS, DO K8s
Issue ticket number and link
#65
Supersedes #84
Checklist before requesting a review