Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Nov 15, 2024

Describe your changes

  • Updates the helm install smoke test with more k8s flavors! Here we add minikube, microk8s and k3d
  • Since they run in parallel, I figured running all cases both on PRs and merges to main is fine for now -- thoughts?

These distros all had GH actions ready-to-use. For other distros we'd like to cover under test (k0s, etc), we could either craft a reusable action in-house and stick to the same matrix-based approach added here... or maybe break out into separate workflows.

Issue ticket number and link

Ref #48

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • K3s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

Copy link
Member

@voigt voigt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to merge this after #264 is merged!

@vdice vdice force-pushed the ci/helm-test-matrix branch 6 times, most recently from 3515709 to a6643dd Compare March 17, 2025 17:59
@vdice
Copy link
Collaborator Author

vdice commented Mar 17, 2025

Weird, currently getting the following from the shim-downloader just from the k3d cluster:

2025-03-17T18:02:12	INFO	start downloading shim from  https://github.com/spinframework/containerd-shim-spin/releases/download/v0.18.0/containerd-shim-spin-v2-linux-x86_64.tar.gz...
gzip: invalid magic
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Trying to figure out the underlying cause...

@voigt
Copy link
Member

voigt commented Mar 17, 2025

Weird, currently getting the following from the shim-downloader just from the k3d cluster:

2025-03-17T18:02:12	INFO	start downloading shim from  https://github.com/spinframework/containerd-shim-spin/releases/download/v0.18.0/containerd-shim-spin-v2-linux-x86_64.tar.gz...
gzip: invalid magic
tar: Child returned status 1
tar: Error is not recoverable: exiting now

Trying to figure out the underlying cause...

Feels like the downloaded file got corrupted... Maybe it would be a good idea to add a bit more verbose info to the downloader script...

Some ideas:

  • removing the -s from curl to get filesize
  • adding an ls -lah to check filesize
  • print md5sum

Generally, printing curl and tar version wouldn't hurt either...

@vdice vdice force-pushed the ci/helm-test-matrix branch 3 times, most recently from a9a5491 to 3841fab Compare March 19, 2025 20:24
@vdice
Copy link
Collaborator Author

vdice commented Mar 19, 2025

I added some debug lines; oddly, I'm seeing variable behavior. (Still only occuring for k3d; the other clusters all succeed.) Sometimes the shim is downloaded just fine and the provisioner proceeds with installation, other times the last log line seen is 'INFO start downloading shim from ...' and the provisioner container is still pending, almost like the download is hanging.

Going to try to repro with a k3d cluster locally and see what I can find...

@vdice vdice force-pushed the ci/helm-test-matrix branch from 29019c9 to 99fb2b1 Compare April 16, 2025 19:19
@vdice vdice force-pushed the ci/helm-test-matrix branch from 62d0572 to 84a0f28 Compare April 16, 2025 21:23
@vdice
Copy link
Collaborator Author

vdice commented Apr 16, 2025

@voigt ok, ready for a re-review. The issue with k3d was due to #371; I've pinned the k8s version to 1.32.1 for the time being.

Do we want any or all of the debug info added to the download_shim.sh script?

@vdice vdice requested a review from voigt April 16, 2025 21:27
@voigt
Copy link
Member

voigt commented Apr 16, 2025

Uh! That was a nasty one. Great that you'll join figured it out!

IMO we should keep the debug info.

@vdice vdice merged commit 68c68ef into spinframework:main Apr 16, 2025
13 checks passed
@vdice vdice deleted the ci/helm-test-matrix branch April 16, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants