- 
                Notifications
    You must be signed in to change notification settings 
- Fork 10
ci(.github): update helm-chart-smoketest with more k8s variations #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to merge this after #264 is merged!
3515709    to
    a6643dd      
    Compare
  
    | Weird, currently getting the following from the shim-downloader just from the k3d cluster: Trying to figure out the underlying cause... | 
| 
 Feels like the downloaded file got corrupted... Maybe it would be a good idea to add a bit more verbose info to the downloader script... Some ideas: 
 Generally, printing curl and tar version wouldn't hurt either... | 
a9a5491    to
    3841fab      
    Compare
  
    | I added some debug lines; oddly, I'm seeing variable behavior. (Still only occuring for k3d; the other clusters all succeed.) Sometimes the shim is downloaded just fine and the provisioner proceeds with installation, other times the last log line seen is 'INFO start downloading shim from ...' and the provisioner container is still pending, almost like the download is hanging. Going to try to repro with a k3d cluster locally and see what I can find... | 
Signed-off-by: Vaughn Dice <[email protected]>
Co-authored-by: Christoph Voigt <[email protected]> Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
29019c9    to
    99fb2b1      
    Compare
  
    Signed-off-by: Vaughn Dice <[email protected]>
62d0572    to
    84a0f28      
    Compare
  
    | @voigt ok, ready for a re-review. The issue with k3d was due to #371; I've pinned the k8s version to 1.32.1 for the time being. Do we want any or all of the debug info added to the download_shim.sh script? | 
| Uh! That was a nasty one. Great that you'll join figured it out! IMO we should keep the debug info. | 
Describe your changes
These distros all had GH actions ready-to-use. For other distros we'd like to cover under test (k0s, etc), we could either craft a reusable action in-house and stick to the same matrix-based approach added here... or maybe break out into separate workflows.
Issue ticket number and link
Ref #48
Checklist before requesting a review