Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Nov 19, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice added this to the M1 - RCM MVP for Spinkube milestone Nov 27, 2024
0xE282B0
0xE282B0 previously approved these changes Jan 20, 2025
Copy link
Collaborator

@0xE282B0 0xE282B0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vdice
Copy link
Collaborator Author

vdice commented Jan 21, 2025

Thanks @0xE282B0; I've just rebased. With your approval, this should be ready to merge.

Copy link
Collaborator

@0xE282B0 0xE282B0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks good.

@vdice vdice merged commit 7dd0449 into spinframework:main Jan 21, 2025
6 checks passed
@vdice vdice deleted the ci/shim-downloader-release branch January 21, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants