Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Nov 19, 2024

Describe your changes

  • Removes the step attempting to get the latest release

We'd need a first release for this to succeed (otherwise it fails with a 404). If we're certain we'll want this step in the future and we'll use the output it provides, I'm happy to update this PR to just comment it out for now.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice added this to the M1 - RCM MVP for Spinkube milestone Nov 27, 2024
Copy link
Collaborator

@0xE282B0 0xE282B0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't use it it can go. We can add it again when needed.

@0xE282B0 0xE282B0 merged commit de1b901 into spinframework:main Jan 20, 2025
6 checks passed
@vdice vdice deleted the ci/rm-latest-release-logic branch January 21, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants