Skip to content

Conversation

@0xE282B0
Copy link
Collaborator

@0xE282B0 0xE282B0 commented Jan 8, 2025

Describe your changes

Replace kwasm.sh with spinkube.dev

Issue ticket number and link

#255

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@0xE282B0 0xE282B0 self-assigned this Jan 8, 2025
@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@0xE282B0
Copy link
Collaborator Author

@vdice is there still a renaming of the project in discussion? - Otherwise I'd continue with this issue.

@vdice
Copy link
Collaborator

vdice commented Jan 21, 2025

@0xE282B0 Yes as far as I know, we still want to use the spinkube.dev domain, to align with spin-operator and other SpinKube projects. I'd endorse proceeding with this refactor and we can double-check with others in the next SpinKube meeting.

@vdice
Copy link
Collaborator

vdice commented Feb 19, 2025

@0xE282B0 are any other changes needed to this draft before opening up for review?

@0xE282B0
Copy link
Collaborator Author

I'll check for missing references tomorrow and then we can proceed with the review.

@0xE282B0 0xE282B0 force-pushed the feat-replace-kwasm.sh branch 4 times, most recently from 1228a69 to e8a416e Compare March 1, 2025 19:44
@0xE282B0 0xE282B0 marked this pull request as ready for review March 1, 2025 20:13
@0xE282B0 0xE282B0 requested review from phyrog, toksikk and vdice March 1, 2025 20:13
Copy link
Collaborator

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xE282B0 0xE282B0 force-pushed the feat-replace-kwasm.sh branch from e8a416e to 2b3fb21 Compare March 5, 2025 18:24
@0xE282B0 0xE282B0 merged commit fc7e27b into main Mar 5, 2025
18 checks passed
@0xE282B0 0xE282B0 deleted the feat-replace-kwasm.sh branch March 5, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants