Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Apr 17, 2025

Describe your changes

Follow-up from #374

Removes the unused/commented-out node_controller.go.

Issue ticket number and link

Ref #222 (comment)

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@vdice vdice force-pushed the chore/rm-node-controller branch from 6ed8b53 to 95851d8 Compare April 17, 2025 16:28
@voigt voigt merged commit 8833668 into spinframework:main Apr 22, 2025
14 checks passed
@vdice vdice deleted the chore/rm-node-controller branch April 22, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants