Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Apr 30, 2025

Noticed this unused env var supplied to the node-installer's provisioner container (as opposed to its downloader init container). Seems like it should be removed.

@vdice vdice force-pushed the chore/rm-installer-fetch-strategy-env-var branch from e896756 to 6e05a56 Compare April 30, 2025 16:46
@vdice vdice requested review from kate-goldenring and voigt June 3, 2025 00:49
Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdice vdice force-pushed the chore/rm-installer-fetch-strategy-env-var branch from 6e05a56 to 4332cbc Compare June 3, 2025 17:26
@vdice vdice merged commit 143e2fc into spinframework:main Jun 4, 2025
14 checks passed
@vdice vdice deleted the chore/rm-installer-fetch-strategy-env-var branch June 4, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants