Skip to content

Conversation

@vdice
Copy link
Collaborator

@vdice vdice commented Jun 11, 2025

Describe your changes

feat: add build/push targets for shim-downloader and node-installer images
fix: export env vars for both images for the make run target

Issue ticket number and link

Ref #387 (comment) re: the fix

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I tested the changes with the following distributions:
    • Kind
    • MiniKube
    • MicroK8s
    • Rancher RKE2
    • Azure AKS
    • GCP GKE (Ubuntu nodes)
    • AWS EKS (AmazonLinux2 nodes)
    • AWS EKS (Ubuntu nodes)
    • Digital Ocean Kubernetes

@github-actions github-actions bot added kind/bug Something isn't working kind/feature labels Jun 11, 2025
@vdice vdice force-pushed the fix-feat/downloader-installer-img-build branch from b05a2c9 to 515338e Compare June 11, 2025 10:09
@voigt voigt merged commit 92681e1 into spinframework:main Jun 11, 2025
14 checks passed
@vdice vdice deleted the fix-feat/downloader-installer-img-build branch June 11, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working kind/feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants